Skip to content

Conversation

Elias0419
Copy link

This PR removes an unused code path in _generate_yaml()in sceptre/cli/helpers.py

yaml.safe_loads() does not exist, so that code path has never done anything.

return yaml.safe_loads(stream)

PR Checklist

  • [✓ ] Wrote a good commit message & description [see guide below].
  • [ ✓] Commit message starts with [Resolve #issue-number].
  • [ ✓] Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • [ ✓] All unit tests (poetry run tox) are passing.
  • [ ✓] Used the same coding conventions as the rest of the project.
  • [ ✓] The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • [ ✓] The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

@zaro0508
Copy link
Contributor

yaml.safe_loads() does not exist

What do you mean it doesn't exist? The latest PyYAML docs seems to refers to its existence.

@Elias0419
Copy link
Author

Hi @zaro0508 - Thanks for having a look

yaml.safe_load exists.

yaml.safe_loads (note the S) does not.

return yaml.safe_loads(stream)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants